cmm: color pipeline preparations - #1105
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR prepares the color-management pipeline by making “no-op / embeddable” decisions render-intent-aware, and by adding infrastructure to reason about whether a target gamut/luminance is contained in a source description.
Changes:
- Thread
RenderIntentintoColorDescription::embeds_into/LinearColorDescription::embeds_intochecks and update call sites (Vulkan renderer, scanout path). - Add cached
LinearColorDescription::target_contained_in_primary()and supporting triangle containment algorithm. - Extend CMM tests to cover target containment behavior and add a
ColorMatrix::IDENTITYconstant.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/gfx_apis/vulkan/renderer.rs | Updates embed checks to pass an explicit render intent for blend-buffer elision and color-transform caching. |
| src/gfx_api.rs | Makes direct-scanout eligibility checks intent-aware via embeds_into(..., ct.render_intent). |
| src/cmm/cmm_transform.rs | Adds a reusable identity matrix constant for future pipeline steps. |
| src/cmm/cmm_tests.rs | Adds tests validating target_contained_in_primary() across multiple primaries/luminance edge cases. |
| src/cmm/cmm_primaries.rs | Adds Primaries::about_equal() for approximate comparisons used by embed checks. |
| src/cmm/cmm_manager.rs | Initializes the new target_contained_in_primary cache field when creating descriptions. |
| src/cmm/cmm_luminance.rs | Refactors white-balance math helpers and adds Luminance::embeds_into(..., intent) for intent-aware identity checks. |
| src/cmm/cmm_description.rs | Adds cached target-containment computation and updates embed logic to use approximate primaries + luminance embedding. |
| algorithms/src/triangles.rs | Introduces a triangle containment helper used by the target-containment computation. |
| algorithms/src/lib.rs | Exposes the new triangles module from the algorithms crate. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.