tree: don't nest redundant containers on repeated split - #1138
Open
michaeladler wants to merge 1 commit into
Open
tree: don't nest redundant containers on repeated split#1138michaeladler wants to merge 1 commit into
michaeladler wants to merge 1 commit into
Conversation
Owner
|
I have not looked at the code, but this needs to be a configuration so as to not break existing workflows. |
michaeladler
force-pushed
the
fix/nested-containers
branch
from
July 30, 2026 07:36
64862f5 to
229ec70
Compare
Author
|
I considered it a bug so I didn't make it configurable initially :) I've made it configurable now. |
mahkoh
reviewed
Jul 30, 2026
mahkoh
reviewed
Jul 30, 2026
mahkoh
reviewed
Jul 30, 2026
mahkoh
reviewed
Jul 30, 2026
mahkoh
reviewed
Jul 30, 2026
Owner
|
LGTM otherwise. |
Splitting a toplevel that is the only child of its parent container wrapped it in yet another single-child container. Repeating the action produced a chain of redundant nesting levels. Change the split direction of the existing container instead.
michaeladler
force-pushed
the
fix/nested-containers
branch
from
July 31, 2026 09:07
f6d2f32 to
e2275ae
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Splitting a top-level container that is the sole child of its parent previously wrapped it in yet another single-child container. Repeating this action created a chain of redundant nesting levels, which is especially noticeable (and somewhat irritating) when borders are enabled.
Instead of creating redundant wrapper containers, this change updates the split direction of the existing parent container.