float: defer size calculation if initially on dummy output - #1148
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR addresses issue #1145 where floating windows can end up with a 0x0 geometry (invisible) after being moved into an overlay workspace, by deferring/redoing initial float positioning when the workspace/output state transitions away from a dummy output.
Changes:
- Track whether a workspace has been on a dummy output and, on the next real extents update, reposition floats that still need an initial size/position.
- Move initial float position computation into
FloatNode::new, including a dummy-output fallback and a sharedcalculate_float_positionhelper. - Add a
FloatNode::set_positionhelper and update call sites/tests to use it.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/tree/workspace.rs | Tracks “was on dummy output” and triggers float repositioning when transitioning to a real output. |
| src/tree/float.rs | Defers initial float sizing/positioning when created on a dummy output; adds set_position; introduces calculate_float_position. |
| src/state.rs | Updates float creation to pass inner dimensions/abs position into FloatNode::new (position computed inside FloatNode). |
| src/it/tests/t0033_float_size_memoization.rs | Updates test to use set_position (but currently contains a coordinate bug needing correction). |
| src/it/tests/t0028_top_level_restacking.rs | Updates test to use set_position. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1145