Client tracing preparations - #1150
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR prepares groundwork for client tracing by extending the wire parser/codegen flow with shared message iteration and request/event metadata, and by adding io_uring futex op support and related SQE/sys updates.
Changes:
- Add io_uring futex wait/wake tasks and integrate them into the io_uring task caching infrastructure.
- Extend io_uring SQE/sys definitions with the new union field and newer opcode constants.
- Refactor wire parsing/codegen to expose
ParseResult::messages()and track whether a parsed message is a request.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| wire-to-xml/src/main.rs | Switch to ParseResult::messages() for unified message iteration when computing protocol version. |
| src/utils/array.rs | Add SliceExt helpers for viewing parts of slices as fixed-size arrays. |
| src/io_uring/sys.rs | Update SQE layout with union6 and extend io_uring opcode constants up to the newer IORING_OP_LAST. |
| src/io_uring/ops/futex.rs | Introduce futex wait/wake io_uring operations and encoding. |
| src/io_uring/ops.rs | Export the new futex ops module. |
| src/io_uring.rs | Wire futex tasks into io_uring caches and re-export FutexObj. |
| build/wire/parser.rs | Track request/event kind per Message and add ParseResult::messages() iterator helper. |
| build/wire.rs | Refactor to parse files first and then write code; use messages() helper for generation. |
Suppressed comments (1)
src/utils/array.rs:36
split_arraycurrently uses unsafe pointer casting andget_unchecked. This can be expressed safely viasplit_at+TryInto, which keeps the method safe without relying onunsafeinternals.
fn split_array<const N: usize>(&self) -> Option<(&[Self::T; N], &[Self::T])> {
if self.len() < N {
return None;
}
let array = unsafe { &*self.as_ptr().cast::<[Self::T; N]>() };
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.