Skip to content

Preparations for overlays - #912

Merged
mahkoh merged 3 commits into
masterfrom
jorth/overlay-preparation
May 3, 2026
Merged

Preparations for overlays#912
mahkoh merged 3 commits into
masterfrom
jorth/overlay-preparation

Conversation

@mahkoh

@mahkoh mahkoh commented May 3, 2026

Copy link
Copy Markdown
Owner

No description provided.

Copilot AI review requested due to automatic review settings May 3, 2026 17:18

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Prepares the tree/focus plumbing for upcoming overlay work by centralizing workspace focus behavior, tightening workspace teardown cleanup, and avoiding invalid output-name emission for dummy outputs in tree queries.

Changes:

  • Added WorkspaceNode::do_focus helper and refactored multiple callers to use it instead of WorkspaceNode::node_do_focus.
  • Ensured workspace teardown cleans up seat-related state via seat_state.destroy_node(...).
  • Updated jay_tree_query workspace visiting to skip sending an output name for dummy outputs.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
src/tree/workspace.rs Adds do_focus helper, refactors node_do_focus to delegate, and destroys seat state during clear().
src/tree/toplevel.rs Switches workspace focus call to use WorkspaceNode::do_focus.
src/tree/output.rs Switches workspace focus calls to use WorkspaceNode::do_focus in multiple paths.
src/tree/container.rs Switches focus restoration to use WorkspaceNode::do_focus.
src/state.rs Uses WorkspaceNode::do_focus when focusing after showing a workspace.
src/ifs/jay_tree_query.rs Skips emitting OutputName for workspaces on dummy outputs.
src/config/handler.rs Removes unused Node import and switches to WorkspaceNode::do_focus.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/tree/workspace.rs
Comment thread src/tree/workspace.rs
@mahkoh
mahkoh merged commit da9648a into master May 3, 2026
16 checks passed
@mahkoh
mahkoh deleted the jorth/overlay-preparation branch May 3, 2026 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants