Preparations for overlays - #912
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Prepares the tree/focus plumbing for upcoming overlay work by centralizing workspace focus behavior, tightening workspace teardown cleanup, and avoiding invalid output-name emission for dummy outputs in tree queries.
Changes:
- Added
WorkspaceNode::do_focushelper and refactored multiple callers to use it instead ofWorkspaceNode::node_do_focus. - Ensured workspace teardown cleans up seat-related state via
seat_state.destroy_node(...). - Updated
jay_tree_queryworkspace visiting to skip sending an output name for dummy outputs.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/tree/workspace.rs | Adds do_focus helper, refactors node_do_focus to delegate, and destroys seat state during clear(). |
| src/tree/toplevel.rs | Switches workspace focus call to use WorkspaceNode::do_focus. |
| src/tree/output.rs | Switches workspace focus calls to use WorkspaceNode::do_focus in multiple paths. |
| src/tree/container.rs | Switches focus restoration to use WorkspaceNode::do_focus. |
| src/state.rs | Uses WorkspaceNode::do_focus when focusing after showing a workspace. |
| src/ifs/jay_tree_query.rs | Skips emitting OutputName for workspaces on dummy outputs. |
| src/config/handler.rs | Removes unused Node import and switches to WorkspaceNode::do_focus. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.