Skip to content

Add schedule - #674

Merged
marcoow merged 50 commits into
mainfrom
add-schedule
Jun 24, 2025
Merged

Add schedule#674
marcoow merged 50 commits into
mainfrom
add-schedule

Conversation

@umbrellarocket

Copy link
Copy Markdown
Contributor

@marcoow Pls review:

  1. Schedule:
    1.1 Since opening/closing talks are now 45 mins long, the schedule has shifted
    1.2 Overall order
    1.3 Schedule talks are not clickable yet as we'd have to fill in all that info + process speaker portraits
  2. Design:
    2.1 Still missing Post-conference day - I will add it in when the rest is approved

@umbrellarocket
umbrellarocket requested a review from marcoow June 13, 2025 11:00
@umbrellarocket
umbrellarocket marked this pull request as draft June 13, 2025 11:00

@marcoow marcoow left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's good overall but some comments:

  • the top section of the schedule page (on desktop specifically) seems a bit unfinished?

    Bildschirmfoto 2025-06-13 um 13 58 54

  • something seems to be wrong with the background image that suddenly ends after the workshop day:

    Bildschirmfoto 2025-06-13 um 13 59 39

    and then starts again at day 2:

    Bildschirmfoto 2025-06-13 um 13 59 45

  • side activities are missing at the end of day 1:

    Bildschirmfoto 2025-06-13 um 14 03 39

  • closing party is missing at the end of day 2:

    Bildschirmfoto 2025-06-13 um 14 03 52

  • would it be nice to have some avatars of the speakers besides their talks maybe to make that page a bit more visual?

Comment thread data/schedule.json Outdated
@umbrellarocket

umbrellarocket commented Jun 13, 2025

Copy link
Copy Markdown
Contributor Author

@marcoow

thanks!

something seems to be wrong with the background image that suddenly ends after the workshop day:

what exactly stands out to you? I replicated the visual separation we have in workshop pages like this one to make the sections stand out more from each other

would it be nice to have some avatars of the speakers besides their talks maybe to make that page a bit more visual?

Yes, that would be great. Do you mean avatars for all speakers or a select few? I can imagine avatars being arranged diagonally like so
image

@marcoow

marcoow commented Jun 13, 2025

Copy link
Copy Markdown
Member

what exactly stands out to you? I replicated the visual separation we have in workshop pages like this one to make the sections stand out more from each other

Hm, might have missed i there – should the image fade in/out maybe? Like this it look like a bug to me?

Yes, that would be great. Do you mean avatars for all speakers or a select few? I can imagine avatars being arranged diagonally like so

I'd say if we do it, should be all speakers

@umbrellarocket

Copy link
Copy Markdown
Contributor Author

@marcoow Pls review again. On top of what we've discussed, I've added:

  • og:Images for all talks
  • all speaker images where available
  • all talk and speaker info
  • day of the week and stage info to each individual talk page
  • navigation to go back to the /schedule page from individual talk and workshop pages

@marcoow marcoow left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's make the after party bigger and add an image:

Bildschirmfoto 2025-06-23 um 09 01 59

It looks like the hover effect on the workshops doesn't work anymore?

Bildschirmfoto 2025-06-23 um 09 02 37

Can we add the speaker photos to the og:images?

Also, the og:images (like all ER visuals) need to include "by Mainmatter" with our logo

Comment thread content/speakers/ada-hieta.md Outdated
@umbrellarocket

Copy link
Copy Markdown
Contributor Author

I'm still working on the og:images but have already asked Linn to take a look at the rest.

@umbrellarocket

Copy link
Copy Markdown
Contributor Author

@marcoow Done on all fronts ✅

@marcoow marcoow left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Let's just rebase on main please.

We could not link the "tba" talks – they all lead to the same empty page anyway.

@marcoow
marcoow marked this pull request as ready for review June 23, 2025 21:32
@mainmatterlinnbp

Copy link
Copy Markdown
Contributor

Looks good to me! Thanks, Xenia.

@marcoow
marcoow merged commit 68e3360 into main Jun 24, 2025
6 checks passed
@marcoow
marcoow deleted the add-schedule branch June 24, 2025 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants