Michael's Instagram Challenge#917
Open
mcsuGH wants to merge 19 commits into
Open
Conversation
…er files and routes
… urls uploaded elsewhere for now
JordanManu
reviewed
May 16, 2022
JordanManu
left a comment
JordanManu
left a comment
There was a problem hiding this comment.
Great project! It works really well, I love the comment feature that displays who commented and the time it was posted. Edge cases were covered and great test coverage!
| - add more CSS - currently only added a bar at the top and a background for the post images, displaying the images in rows of 3. | ||
| - make it so each user can only like a post once (would just need to create a new collection for likes inside database with foreign keys for the post and the user who liked the post) | ||
| - add filter function | ||
| - add the ability to upload images onto the database rather than using a external image host |
There was a problem hiding this comment.
Great readme instructions, very easy to follow
| }) | ||
| } | ||
| } | ||
|
|
| cy.get(".createpost").click(); | ||
|
|
||
| cy.url().should("include", "/posts"); | ||
| cy.get('div[class="posts"]').find(".postimage").should('be.visible'); |
|
|
||
| cy.url().should("include", "/sessions"); | ||
| cy.should("not.contain", "Hey someone3@example.com"); | ||
| }); |
| cy.get("#password").type("password"); | ||
| cy.get("#submit").click(); | ||
|
|
||
| cy.contains("Email already in use"); |
| expect(err).toBeNull(); | ||
|
|
||
| expect(posts[0].createdAt).toBeDefined(); | ||
| done(); |
| {{/if}} | ||
| </div> | ||
| {{#if user}} | ||
| Hey {{user.email}} |
| <input type="text" id="comment" name="comment" placeholder="write comment" required> | ||
| </div> | ||
| <div> | ||
| <button class ='createcomment'>Comment</button> |
| </div> | ||
| <br> | ||
| <form action = '/posts'> | ||
| <button class = "back">back</button> |
| @@ -0,0 +1,17 @@ | |||
| {{#if user}} | |||
| You are already logged in. | |||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implemented most of the functionality (can make post, comment on posts, like on posts). Users can sign in and sign out and conditionals are used to show content depending on whether or not the user is signed in or not (for example, if you are signed in, the Sign In button at the navigation bar becomes a Log Out, or if you are already logged in and you go to the Login Page it will tell you you are already logged in.)
Will need to add functionality to upload images to database (currently only allows URL of external image hosts like imgur) and still need to add more CSS to make it look nicer.