Skip to content

Joe McNally Instagram Challenge Partial Submission#919

Open
jmcnally17 wants to merge 12 commits into
makersacademy:mainfrom
jmcnally17:main
Open

Joe McNally Instagram Challenge Partial Submission#919
jmcnally17 wants to merge 12 commits into
makersacademy:mainfrom
jmcnally17:main

Conversation

@jmcnally17

@jmcnally17 jmcnally17 commented May 15, 2022

Copy link
Copy Markdown

Joe McNally

User stories

  • User story 1: "I want to view the homepage"
  • User story 2: "I want to sign up"
  • User story 3: "I want to be able to log in"
  • User story 4: "I want to post a photo"
  • User story 5: "I want to like photos"
  • User story 6: "I want to comment on photos"
  • User story 7: "I want to be able to delete my photos"
    Bonus:
  • User story 8: "I want to add filters to my photos"

@almorcrette almorcrette left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Joe, thanks for sharing and allowing to take a look.

Well done on set up the whole project from scratch yourself instead of using the Acebook node seed like most of us did. It works great.

The approach to loading and displaying photos via urls works ok. I was able to load a jpg as well as a png I found on the web. It didn't work when I tried to load up a public llink to a couple of my own photos I have on google photos though. So it's not clear how I would share my own photos.

Jest is missing from json.packages but once installed the tests run fine and all pass. A newxt step could be to build out the tests for the functionality you built.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants