Joe McNally Instagram Challenge Partial Submission#919
Open
jmcnally17 wants to merge 12 commits into
Open
Conversation
almorcrette
reviewed
May 16, 2022
almorcrette
left a comment
There was a problem hiding this comment.
Hi Joe, thanks for sharing and allowing to take a look.
Well done on set up the whole project from scratch yourself instead of using the Acebook node seed like most of us did. It works great.
The approach to loading and displaying photos via urls works ok. I was able to load a jpg as well as a png I found on the web. It didn't work when I tried to load up a public llink to a couple of my own photos I have on google photos though. So it's not clear how I would share my own photos.
Jest is missing from json.packages but once installed the tests run fine and all pass. A newxt step could be to build out the tests for the functionality you built.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Joe McNally
User stories
Bonus: