sound/namco.cpp: Updates - #15154
Merged
Merged
Conversation
- Use device_memory_interface for waveform memory, allow config per hardware (ex: RAM in 20pacgal.cpp) - Split Pole Position WSG into separated device - Add address map for common 15XX/CUS30 interface - Remove unnecessary configurations, Use template instead (also packed flag) - Add notes for polepos panning - Fix mixing - Use logmacro.h for logging - Reduce preprocessor macros - Split device state for per-hardware differs - Fix allocated size for sound register area - Fix namings - Use references to replace pointer - Make some variables constant namco/20pacgal.cpp, namco/polepos.cpp: - Correct sound device type
This core only covers namco's WSG sound generator. (standard 3 voice, pole position 8 voice variation, 15XX family, CUS30)
…t is known to compiler.
stonedDiscord
pushed a commit
to stonedDiscord/mame
that referenced
this pull request
Apr 14, 2026
* Use device_memory_interface for waveform memory, allow config per hardware (ex: RAM in 20pacgal.cpp). * Split Pole Position WSG into separate device. * Added address map for common 15XX/CUS30 interface. * Remove unnecessary configuration, use templated base class instead (also packed flag). * Added notes for polepos panning. * Fixed mixing. * Use logmacro.h for logging, reduced preprocessor macros, use references rather than pointers. * Split device state for per-hardware differences. * Fix allocated size for sound register area. * Made some variables const. * namco/20pacgal.cpp, namco/polepos.cpp: Corrected sound device type.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
namco/20pacgal.cpp, namco/polepos.cpp: