misc/vamphalf.cpp: Updates - #15302
Merged
Merged
Conversation
- Add korean game titles if exists - Add side effect check for debugger reads - Reduce duplicates - Fix save state support - Fix initialization - Use BIT helper for single bit values - Reduce literal tag usages - Fix spacings
angelosa
reviewed
May 3, 2026
| if (!machine().side_effects_disabled()) | ||
| m_semicom_prot_idx--; | ||
| return (m_semicom_prot_data[m_semicom_prot_which] & (1 << m_semicom_prot_idx)) >> m_semicom_prot_idx; | ||
| return BIT(m_semicom_prot_data[m_semicom_prot_which], m_semicom_prot_idx) ? SetValue : 0; |
Member
There was a problem hiding this comment.
fwiw I plan to change misncrft, wivernwg (and I guess worldadv) to actual composed devices, rather than having to separate state machines (which is a separate matter, this driver sure needs splits).
cfr. #9414
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.