readme.org - ZMK Docker Build Subsection#57
Open
axiom-nz wants to merge 1 commit intomanna-harbour:masterfrom
Open
readme.org - ZMK Docker Build Subsection#57axiom-nz wants to merge 1 commit intomanna-harbour:masterfrom
axiom-nz wants to merge 1 commit intomanna-harbour:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
The
Local Buildsection ofreadme.orgspecifies thatZMK_CONFIGbe set to the absolute path of the config directory.When using the local docker build environment, following these instructions would lead the user to create their
zmk-configdocker volume with a device path set to config.Doing so will exclude the Miryoku code from the volume, and any build will fail.
Failing Build
With
miryoku_zmk/configprovided as the device path.Resolution
Adding subsection to the local build documentation to inform those using the docker build environment of this, and give instructions on the correct path.
Successful Build
With
miryoku_zmkprovided as the device path.Let me know if there is any issue with this, or if you would like it phrased differently.