BUG FIX: reset text frame index when spinner text is reassigned#192
Open
SAY-5 wants to merge 1 commit into
Open
BUG FIX: reset text frame index when spinner text is reassigned#192SAY-5 wants to merge 1 commit into
SAY-5 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of new feature, or changes
The
textsetter rebuilds the animation frames but never reset_text_index, so reassigning a shorter animated message while a spinner is running raisesIndexError: list index out of rangeintext_frame(). This resets the index, matching what thespinnersetter already does.Checklist
Related Issues and Discussions
Fixes #162
People to notify