Add leg notifications - #230
Open
jsparidaans wants to merge 2 commits into
Open
Conversation
📝 WalkthroughWalkthroughAdds serializable route-leg notification models, integrates notifications into ChangesRoute-leg notifications
Estimated code review effort: 3 (Moderate) | ~20 minutes Sequence Diagram(s)sequenceDiagram
participant JSON
participant RouteLeg
participant Notification
JSON->>RouteLeg: Decode notifications array
RouteLeg->>Notification: Deserialize each notification
Notification-->>RouteLeg: Populate notification fields and details
RouteLeg-->>JSON: Serialize mapped wire field names
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
3 tasks
rubenmx
approved these changes
Aug 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
In this PR we are adding notifications to route legs. These offer us the possibility to warn drives of potential risks on their route. These notifications are implemented in accordance with the Mapbox spec outlined here.
Why
At Flitsmeister we are looking to implement ferry notifications in our routing module. At the moment the DirectionsRoute object does not know how to parse said ferry notifications, so we could either parse the raw json ourselves and hack some way around it, or we could add it to the DirectionsRoute object as an expansion.
Summary by CodeRabbit
New Features
Tests