Make sure docgen uses induced slots - #408
Merged
Merged
Conversation
Before, slot information was taken outside the context of a specific class (not induced), which led to wrong rendering in the docs.
sujaypatil96
requested changes
Jan 6, 2025
sujaypatil96
left a comment
sujaypatil96
left a comment
Contributor
There was a problem hiding this comment.
The logic you've written here is partially correct, but iterating over c.slots is not as comprehensive as using class_slots() from SchemaView.
It might be better to switch over to using the class_induced_slots() method which i've linked out to in my review comments.
I'm happy to do it too, so let me know if you need help!
Contributor
|
We might not need any changes here? See my response on the related issue: #406 (comment) |
sujaypatil96
approved these changes
Jul 16, 2025
Collaborator
Author
|
Thanks a ton @sujaypatil96! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before, slot information was taken outside the context of a specific class (not induced), which led to wrong rendering in the docs.
Resolves #406
docs/have been added/updated if necessarymake testhas been run locallytests have been added/updated (if applicable)CHANGELOG.md has been updated.If you are proposing a change to the SSSOM metadata model, you must
examples/see_alsofield of the linkml modelsee_alsofield of the linkml model