Skip to content

Regenerate project files - #532

Merged
cthoyt merged 3 commits into
masterfrom
update-project
Apr 14, 2026
Merged

Regenerate project files#532
cthoyt merged 3 commits into
masterfrom
update-project

Conversation

@cthoyt

@cthoyt cthoyt commented Apr 8, 2026

Copy link
Copy Markdown
Member

This PR regenerates the project files using the make gen-project target. I mistakenly thought this was part of the release workflow. In a follow-up PR, I will implement something to make sure that any change of the underlying schema YAML is also accompanied by a regeneration of the project files

  • docs/ have been added/updated if necessary
  • make test has been run locally
  • tests have been added/updated (if applicable)
  • CHANGELOG.md has been updated.

@cthoyt
cthoyt marked this pull request as ready for review April 14, 2026 07:39
@cthoyt
cthoyt requested review from gouttegd and matentzn and removed request for matentzn April 14, 2026 14:00
@gouttegd

gouttegd commented Apr 14, 2026

Copy link
Copy Markdown
Contributor

I will implement something to make sure that any change of the underlying schema YAML is also accompanied by a regeneration of the project files

Please don’t. This is a very bad idea as it will cause needless conflicts whenever two PRs change the schema: even if the changes to the schema are not themselves conflicting, the schema-derived generated files are almost bound to conflict, forcing the author of one PR to go through a perfectly avoidable conflict resolution once the other PR is merged first.

Better to keep the generated files as they are during a development cycle and re-generate them once and for all shortly before a release (including a beta release if needed).

@cthoyt
cthoyt enabled auto-merge (squash) April 14, 2026 14:36
@cthoyt
cthoyt requested a review from matentzn April 14, 2026 14:36
@cthoyt
cthoyt merged commit 0ab80d4 into master Apr 14, 2026
3 checks passed
@cthoyt

cthoyt commented Apr 14, 2026

Copy link
Copy Markdown
Member Author

@matentzn can we get a new alpha release that includes the regenerated files?

@cthoyt
cthoyt deleted the update-project branch April 14, 2026 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants