Gracefully handling missing reels file, and creation timestamps

src/instagram-to-bluesky.test.ts

@@ -1,5 +1,3 @@
-import fs from "fs";
-
 import {
   main,
   formatDuration,
@@ -9,7 +7,7 @@
 import { BlueskyClient } from "./bluesky/bluesky";
 import { ImagesEmbedImpl, VideoEmbedImpl } from "./bluesky/index";
 import { logger } from "./logger/logger";
-import { InstagramMediaProcessor, ImageMediaProcessResultImpl } from "./media";
+import { InstagramMediaProcessor, ImageMediaProcessResultImpl, readJsonFile } from "./media";
 
 import type { InstagramExportedPost } from "./media/InstagramExportedPost";
 
@@ -66,6 +64,7 @@
         process: mockProcess,
       })),
     decodeUTF8: jest.fn((x) => x),
+    readJsonFile: jest.fn(),
     ImageMediaProcessResultImpl: actual.ImageMediaProcessResultImpl,
     VideoMediaProcessResultImpl: actual.VideoMediaProcessResultImpl
   };
@@ -103,9 +102,9 @@
   const mockReadFileSync = (mockValue) => {
     return (path) => {
       if (path.endsWith('reels.json')) {
-        return JSON.stringify({"ig_reels_media": mockValue})
+        return JSON.parse(JSON.stringify({ "ig_reels_media": mockValue }))
       }
-      return JSON.stringify(mockValue)
+      return JSON.parse(JSON.stringify(mockValue));
     }
   };
 
@@ -135,7 +134,7 @@
         ],
       },
     ];
-    (fs.readFileSync as jest.Mock).mockImplementation(mockReadFileSync(mockValue));
+    (readJsonFile as jest.Mock).mockImplementation(mockReadFileSync(mockValue));
 
     // Reset BlueskyClient mock
     jest.mocked(BlueskyClient).mockClear();
@@ -172,7 +171,7 @@
       ],
     };
 
-    (fs.readFileSync as jest.Mock).mockImplementation(mockReadFileSync([mockPost]));
+    (readJsonFile as jest.Mock).mockImplementation(mockReadFileSync([mockPost]));
 
     await main();
 
@@ -200,7 +199,7 @@
       ],
     };
 
-    (fs.readFileSync as jest.Mock).mockImplementation(mockReadFileSync([oldPost]));
+    (readJsonFile as jest.Mock).mockImplementation(mockReadFileSync([oldPost]));
 
     await main();
 
@@ -223,7 +222,7 @@
       ],
     };
 
-    (fs.readFileSync as jest.Mock).mockImplementation(mockReadFileSync([futurePost]));
+    (readJsonFile as jest.Mock).mockImplementation(mockReadFileSync([futurePost]));
 
     await main();
 
@@ -247,7 +246,7 @@
         ],
       };
 
-      (fs.readFileSync as jest.Mock).mockImplementation(mockReadFileSync([exactMinDatePost]));
+      (readJsonFile as jest.Mock).mockImplementation(mockReadFileSync([exactMinDatePost]));
 
       await main();
 
@@ -277,7 +276,7 @@
         ],
       };
 
-      (fs.readFileSync as jest.Mock).mockImplementation(mockReadFileSync([exactMaxDatePost]));
+      (readJsonFile as jest.Mock).mockImplementation(mockReadFileSync([exactMaxDatePost]));
 
       await main();
 
@@ -340,7 +339,7 @@
         },
       ];
 
-      (fs.readFileSync as jest.Mock).mockImplementation(mockReadFileSync(posts));
+      (readJsonFile as jest.Mock).mockImplementation(mockReadFileSync(posts));
 
       await main();
 
@@ -391,7 +390,7 @@
         },
       ];
 
-      (fs.readFileSync as jest.Mock).mockImplementation(mockReadFileSync(posts));
+      (readJsonFile as jest.Mock).mockImplementation(mockReadFileSync(posts));
 
       await main();
 
@@ -416,15 +415,15 @@
       media: [{ title: "Invalid Media" }],
     };
 
-    (fs.readFileSync as jest.Mock).mockImplementation(mockReadFileSync([invalidPost]));
+    (readJsonFile as jest.Mock).mockImplementation(mockReadFileSync([invalidPost]));
 
     await main();
 
     expect(logger.warn).toHaveBeenCalledWith("Skipping post - No date");
   });
 
   test("should handle file reading errors", async () => {
-    (fs.readFileSync as jest.Mock).mockImplementation(() => {
+    (readJsonFile as jest.Mock).mockImplementation(() => {
       throw new Error("File read error");
     });
 
@@ -443,7 +442,7 @@
       ],
     };
 
-    (fs.readFileSync as jest.Mock).mockImplementation(mockReadFileSync([mockPost]));
+    (readJsonFile as jest.Mock).mockImplementation(mockReadFileSync([mockPost]));
     jest.mocked(BlueskyClient).prototype.createPost = jest
       .fn()
       .mockRejectedValue(new Error("Post failed"));
@@ -469,7 +468,7 @@
       ],
     };
 
-    (fs.readFileSync as jest.Mock).mockImplementation(mockReadFileSync([mockPost]));
+    (readJsonFile as jest.Mock).mockImplementation(mockReadFileSync([mockPost]));
 
     await main();
 
@@ -507,7 +506,7 @@
       ],
     };
 
-    (fs.readFileSync as jest.Mock).mockImplementation(mockReadFileSync([mockPost]));
+    (readJsonFile as jest.Mock).mockImplementation(mockReadFileSync([mockPost]));
     await main();
 
     expect(jest.mocked(BlueskyClient)).toHaveBeenCalled();
@@ -550,7 +549,7 @@
       ],
     };
 
-    (fs.readFileSync as jest.Mock).mockImplementation(mockReadFileSync([mockPost]));
+    (readJsonFile as jest.Mock).mockImplementation(mockReadFileSync([mockPost]));
 
     const embeddedMedia = mockPost.media.map(() => ({
       getType: () => "image",
@@ -651,7 +650,7 @@
 describe("uploadMediaAndEmbed", () => {
   test("should handle multiple images correctly", async () => {
     const mockBluesky = {
       uploadMedia: jest.fn().mockImplementation((_, __) =>
         Promise.resolve({
           ref: `test-blob-ref-${mockBluesky.uploadMedia.mock.calls.length}`,
           mimeType: "image/jpeg",

src/instagram-to-bluesky.ts

@@ -1,4 +1,3 @@
-import FS from "fs";
 import path from "path";
 
 import { BlobRef } from "@atproto/api";
@@ -20,6 +19,8 @@ import {
   decodeUTF8,
   InstagramMediaProcessor,
   InstagramExportedPost,
+  readJsonFile,
+  sortPostsByCreationTime,
 } from "./media";
 
 const API_RATE_LIMIT_DELAY = 3000; // https://docs.bsky.app/docs/advanced-guides/rate-limits
@@ -171,15 +172,18 @@ export async function main() {
     );
   }
 
-  // Read instagram posts JSON file as raw buffer data.
-  const instaPostsFileBuffer: Buffer = FS.readFileSync(postsJsonPath);
-  const instaReelsFileBuffer: Buffer = FS.readFileSync(reelsJsonPath);
+  // Read posts and reels data
+  const instaPostsData = readJsonFile(postsJsonPath, 'No posts found. The file path may have changed - please update the env to point to the new folder containing posts_1.json');
+  const reelsJsonData = readJsonFile(reelsJsonPath, 'No reels found. Some accounts don\'t have reels, or the folder may have changed.');
 
-  // Decode raw JSON data into an object.
-  const allInstaPosts: InstagramExportedPost[] = decodeUTF8([].concat(
-    JSON.parse(instaPostsFileBuffer.toString()),
-    JSON.parse(instaReelsFileBuffer.toString())['ig_reels_media']
-  ));
+  // Extract reels data (some users don't have reels)
+  const instaReelsData = reelsJsonData['ig_reels_media'] || [];
+
+  // Decode raw JSON data into an object
+  const allInstaPosts: InstagramExportedPost[] = decodeUTF8([
+    ...instaPostsData,
+    ...instaReelsData
+  ]);
 
   // Initialize counters for posts and media.
   let importedPosts = 0;
@@ -188,12 +192,7 @@ export async function main() {
 
   // Sort instagram posts by creation timestamp
   if (allInstaPosts && allInstaPosts.length > 0) {
-    const sortedPosts = allInstaPosts.sort((a, b) => {
-      // Get the first posts media and compare timestamps.
-      const ad = a.media[0].creation_timestamp;
-      const bd = b.media[0].creation_timestamp;
-      return ad - bd;
-    });
+    const sortedPosts = allInstaPosts.sort(sortPostsByCreationTime)
 
     // Preprocess posts before transforming into a normalized format.
     for (const post of sortedPosts) {