Skip to content

Enable ARM when the processor is detected as arm64#1037

Open
gregtatum wants to merge 1 commit into
marian-nmt:masterfrom
gregtatum:marian-nmt-master
Open

Enable ARM when the processor is detected as arm64#1037
gregtatum wants to merge 1 commit into
marian-nmt:masterfrom
gregtatum:marian-nmt-master

Conversation

@gregtatum

Copy link
Copy Markdown

Description

Building on macOS doesn't detect correctly that it is on an ARM processor.

List of changes:

  • Adds a new if branch for ARM64.

Added dependencies: none

How to test

Run cmake on a macOS arm64 machine, and do a build. It will correctly set ARM to being on. The make test command works, but the full regression tests don't work on a CPU macOS ARM64 build.

Checklist

  • I have tested the code manually
  • I have run regression tests
  • I have read and followed CONTRIBUTING.md
  • I have updated CHANGELOG.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant