Skip to content

[nightshift] fix documentation drift - #9132

Open
marin-ops-agent[bot] wants to merge 3 commits into
mainfrom
nightshift/docs-design-drift
Open

marin-ops-agent[bot] wants to merge 3 commits into
mainfrom
nightshift/docs-design-drift

Conversation

@marin-ops-agent

@marin-ops-agent marin-ops-agent Bot commented Sep 13, 2026

Copy link
Copy Markdown
Contributor

Seed hums, digits drift —
the doc still names a river
the code rerouted.

docs/design/finelog-exact-analytics.md describes Finelog's segment index
family in the present tense, and the implementation moved past it.

The IndexSpec enum listed four variants; it now has six. Document
AdaptiveValueCounts and AdaptiveGroupExtrema, their query families, and the
Schema.grouped_extrema declaration that drives the second one. Adaptive
sections are best-effort: a segment that declines one above its cardinality or
byte budget stays complete, while a missing declared ValueCounts section still
makes the bundle stale.

Value-count substitution no longer requires complete coverage across visible
segments. Contained segments read summaries, boundary and L0 segments keep an
ordinary aggregate, and a final aggregate merges both exactly; grouped extrema
use the same shape under FinelogGroupExtrema.

Correct the training-status projection column list, which was missing
run_id, job_id, and attributes_json, and record that the telemetry schema
now declares fourteen projections rather than one. Mark the benchmark section as
the acceptance run for the original four-method family so its numbers are not
read as current.

The other five docs under docs/design/ were checked against the code in the
same pass. Their file paths, symbols, and config values still resolve, and the
markdown links are intact.

The `IndexSpec` enum listed four variants; it now has six. Document
`AdaptiveValueCounts` and `AdaptiveGroupExtrema`, their query families, and the
`Schema.grouped_extrema` declaration that drives the second one. Adaptive
sections are best-effort: a segment that declines one above its cardinality or
byte budget stays complete, while a missing declared `ValueCounts` section still
makes the bundle stale.

Value-count substitution no longer requires complete coverage across visible
segments. Contained segments read summaries, boundary and L0 segments keep an
ordinary aggregate, and a final aggregate merges both exactly; grouped extrema
use the same shape under `FinelogGroupExtrema`.

Correct the `training-status` projection column list, which was missing
`run_id`, `job_id`, and `attributes_json`, and record that the telemetry schema
now declares fourteen projections rather than one. Mark the benchmark section as
the acceptance run for the original four-method family so its numbers are not
read as current.
@marin-ops-agent marin-ops-agent Bot added agent-generated Created by automation/agent nightshift Automated nightshift fixes labels Sep 13, 2026
@marin-ops-agent
marin-ops-agent Bot enabled auto-merge (squash) September 13, 2026 14:51
@marin-ops-agent
marin-ops-agent Bot requested a review from rjpower September 13, 2026 14:51
@marin-ops-agent marin-ops-agent Bot added the agentic-lint Local agentic lint review completed label Sep 13, 2026
@marin-ops-agent

Copy link
Copy Markdown
Contributor Author

🤖 Note on the agentic-lint label: the per-lane review harness could not run in
this runner. ./infra/pre-commit.py --review spawned claude -p for each lane
and every lane exited immediately with Not logged in, so no findings were
produced (logs under /tmp/marin-linter/nightshift-docs-design-drift/).

I ran the infra/lint/ catalog over the branch diff directly instead. The diff
is prose-only in one design doc. The applicable prose rules are
ml-stale-docstring and ml-docstring-contradicts-impl, which this change
fixes rather than introduces. Two wordings were tightened in the follow-up
commit: a not an exception stock contrast and a redundant clause in the
benchmark caveat.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 75727dd8b8

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread docs/design/finelog-exact-analytics.md Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent-generated Created by automation/agent agentic-lint Local agentic lint review completed nightshift Automated nightshift fixes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants