fix: path mismatches in tests on Windows and macOS#50
Open
semihbkgr wants to merge 2 commits intomark3labs:mainfrom
Open
fix: path mismatches in tests on Windows and macOS#50semihbkgr wants to merge 2 commits intomark3labs:mainfrom
semihbkgr wants to merge 2 commits intomark3labs:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Tests were failing on Windows but passing on macOS and Linux due to differences in how paths are resolved.
Root Cause
t.TempDir()returns 8.3 short names (e.g.,RUNNER~1) in GitHub Actions, whilefilepath.EvalSymlinks()resolves these to long names (e.g.,runneradmin). This mismatch caused assertions to fail./var/foldersresolving to/private/var/folders), but still preserves substring relationships, so the tests passed (the checks are false negative)Solution
Normalize all expected paths in the tests by applying
filepath.EvalSymlinks()before assertions. This ensures consistent behavior across all platforms: on Windows, it resolves 8.3 short names to their long form, and on macOS, it resolves symlinks to their canonical paths.