refactor: wire SELinux label_volumes into runtime volume handling#50
Merged
markhedleyjones merged 2 commits intomainfrom Mar 25, 2026
Merged
refactor: wire SELinux label_volumes into runtime volume handling#50markhedleyjones merged 2 commits intomainfrom
markhedleyjones merged 2 commits intomainfrom
Conversation
ensure_selinux_label and label_volumes existed in volumes.py but were never called from source code. User-defined runtime volumes were passed to docker/podman without SELinux :z labels, which can cause permission denied errors on SELinux-enabled systems. Apply label_volumes to user-defined volumes in both cm run and run.sh generation. Internally-generated mounts (workspace, AWS, manifest) already have :z hardcoded.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ensure_selinux_label and label_volumes existed in volumes.py but were never called from source code. User-defined runtime volumes were passed to docker/podman without SELinux :z labels, which can cause permission denied errors on SELinux-enabled systems.
Apply label_volumes to user-defined volumes in both cm run and run.sh generation. Internally-generated mounts (workspace, AWS, manifest) already have :z hardcoded.