Merged
Conversation
…on exit - Guard against empty or non-mapping cm.yaml in from_yaml (crashes with confusing TypeError) - Read __version__ from package metadata instead of hardcoding 0.1.0 (was never updated by semantic-release) - Add trap for manifest temp file cleanup in run.sh command functions (leaked on SIGINT or container failure) - Redirect runtime detection error to stderr in run.sh
- "Initialize"/"Initializing" to "Initialise"/"Initialising" in cli help text and messages - cached-assets.md incorrectly said cm update downloads assets; only cm build does
- _macros.j2 defined a symlink_mounts macro never imported by any
template
- asset.get("dest") in cache list command referenced a key that
list_cached_assets never sets
Move duplicated _generate (generate_dockerfile_from_dict) and _get_stage_block (get_stage_block) helpers into tests/unit/conftest.py. Previously defined independently in test_pip_venv.py, test_implicit_user.py, test_dockerfile_output.py, and test_assets.py.
…ards - Rename _build_feature_flags to build_feature_flags and import it in run_script.py instead of duplicating the dict construction - Remove "if config.runtime else" guards throughout run_script.py and runner.py since RuntimeConfig always has a default_factory
14 tests covering the main code paths: basic args, workspace mount, workdir, image not found, ipc/network/privileged modes, volume expansion with SELinux labels, device passthrough, ad-hoc exec form, custom command shell wrapping with env vars and ports, and detach mode.
markhedleyjones
force-pushed
the
fix/codebase-review-cleanup
branch
from
9e9a7b2 to
a0517e1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses findings from full codebase review: