Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #139.
This is an initial implementation of mermaid diagrams powered by
beautiful-mermaid, with zero DOM dependency and a synchronous rendering.Developers who uses Marp Core in own system can benefit of mermaid diagram support in
Marp.prototype.render()without having to think about JS running environment.Marp Core v5 has implemented Shiki highlighter support (#413), and the theme of
beautiful-mermaiddiagrams also uses Shiki's.Blockers
require("beautiful-mermaid")in Node.js throwsERR_PACKAGE_PATH_NOT_EXPORTEDlukilabs/beautiful-mermaid#73#417 considers to apply lazy loading modules by
require('beautiful-mermaid')to stop bloating the core, but currently it is not working on Node.js due to lacked definition inbeautiful-mermaid'spackage.json. I've sent a pull request lukilabs/beautiful-mermaid#74 but the project seems to be no activities for about a month.