[AspNetCore] Do not add built-in tags for v11+#2
[AspNetCore] Do not add built-in tags for v11+#2martincostello wants to merge 1 commit intodotnet-vnextfrom
Conversation
src/OpenTelemetry.Instrumentation.AspNetCore/Implementation/HttpInListener.cs
Show resolved
Hide resolved
| @@ -206,17 +214,22 @@ public void OnStartActivity(Activity activity, object? payload) | |||
| TelemetryHelper.RequestDataHelper.SetHttpMethodTag(activity, request.Method); | |||
|
|
|||
| activity.SetTag(SemanticConventions.AttributeUrlScheme, request.Scheme); | |||
There was a problem hiding this comment.
Aren't values like this still set when .NET 11? Shouldn't everything alraedy be set by ASP.NET Core? If values are missing, should consider adding them to ASP.NET Core.
There was a problem hiding this comment.
I'll take a look.
So far this PR was just removing the stuff I saw in the diff of your PR. If some of it was being added already anyway in 10, then I can trim stuff out separately in main.
There was a problem hiding this comment.
Was added in dotnet/aspnetcore#62090, so we should be able to drop some stuff for .NET 10 in the current codebase ahead of .NET 11.
I'll work on that now, then come back to these changes once those are merged.
There was a problem hiding this comment.
I've identified two things that are missing in .NET 11 - I'll create an issue there for discussion.
There was a problem hiding this comment.
Do not add tags to activities for ASP.NET Core 11 that are already added by the framework. Relates to open-telemetry#3808.
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
2 participants
Relates to open-telemetry#3808.
Changes
Do not add tags to activities for ASP.NET Core 11 that are already added by the framework.
Merge requirement checklist
Unit tests added/updatedAppropriateCHANGELOG.mdfiles updated for non-trivial changesChanges in public API reviewed (if applicable)