fix: don't use f64 to calculate intervals#25
Merged
Conversation
martinohmann
force-pushed
the
interval-while-loop
branch
2 times, most recently
from
21b1906 to
15f24bf
Compare
We now always add `Span`s, which ensures that we correctly deal with things like leap years and months of different length. This also fixes a couple of bugs along the way. E.g. different logic for picking the closest datetime if there's an equal distance.
martinohmann
force-pushed
the
interval-while-loop
branch
from
15f24bf to
2b0e2e9
Compare
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We now always add
Spans, which ensures that we correctly deal with things like leap years and months of different length.This also fixes a couple of bugs along the way. E.g. different logic for picking the closest datetime if there's an equal distance.