Fix admin refresh failures by migrating scraper to paginated all-time API#1
Open
Disseminator wants to merge 3 commits into
Open
Fix admin refresh failures by migrating scraper to paginated all-time API#1Disseminator wants to merge 3 commits into
Disseminator wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes
POST /api/admin/refreshreturning 500 when scraping skills data.Root Cause
The scraper was parsing
https://skills.shHTML with a hardcodedallTimeSkillsregex.The site payload format changed, so that key is no longer reliably present in page HTML.
Changes
GET /api/skills/all-time/{page}(0-based)hasMore/total).source + skillIdallTimeSkillsinitialSkillssrc/registry/scraped-skills.jsonto.gitignore(generated file).Result
Manual refresh no longer depends on fragile HTML structure and is resilient to future frontend payload changes.