-
Notifications
You must be signed in to change notification settings - Fork 0
⚡ Bolt: [performance improvement] Reduce eventqueue GC pressure #24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
matdev83
merged 2 commits into
main
from
bolt-eventqueue-optimization-8043453630250216761
Jun 22, 2026
Merged
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| ## 2024-05-18 - PendingEventQueue reallocation overhead | ||
| **Learning:** The `PendingEventQueue` in `internal/core/stream` translates large wire chunks into many canonical events. Its compaction logic was reallocating an entire new slice with every shift if the queue dropped below 50% capacity and its capacity was over 32. Since these queues process rapidly arriving stream events, shifting head-to-tail down the existing array via `copy` is much cheaper than `make`+`copy` except when the array has bloated excessively (>1024 cap and <25% active). | ||
| **Action:** Always prefer `copy(q[:alive], q[head:])` for circular/sliding queues and avoid reallocating `next := make(...)` unless actually shrinking a bloated buffer (e.g. `cap > 1024` and `alive < cap / 4`). Benchmark: pushPop throughput improved ~35% (175k ns -> 126k ns) and allocs dropped from 13 to 9. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.