Feature/update user endpoint - #101
Open
DimaDamage91 wants to merge 4 commits into
Open
Conversation
Follows the existing getUserById pattern: returns undefined when the id doesn't exist, or the mutated user otherwise. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Validates that name and email are non-empty strings before touching the store, so a bad body 400s even for an id that exists. Falls back to 404 when the store returns no user (covers both an unknown id and a non-numeric one). Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Self-review caught that the store received the raw (untrimmed) values even though validation checked the trimmed ones, so whitespace-padded input was persisted verbatim. Also hoisted the isFilledString check to module scope so it isn't recreated on every request. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.