Add PUT /users/:id (update a user) - #103
Open
sernadesigns wants to merge 4 commits into
Open
Conversation
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011zurgX4yh3itGEaer5Z3A8
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011zurgX4yh3itGEaer5Z3A8
updateUser now reuses getUserById instead of re-implementing the id lookup, and POST/PUT share a hasNameAndEmail validator instead of duplicating the required-field check. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RL3gsnyHshwFzHxGZAwpDM
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RL3gsnyHshwFzHxGZAwpDM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PUT /users/:idto update an existing user's name and email, following the conventions already used by the other user routes (db/store.js#updateUser,routes/users.js).updateUsernow reusesgetUserByIdfor its lookup, and POST/PUT share ahasNameAndEmailvalidator instead of each duplicating the required-field check.CLAUDE.mdandNOTES.mddocumenting the project and the process behind this change.Test plan
npm test— all 9 tests pass, including the 3 intests/update-user.test.jsnpm run lint— cleanhttps://claude.ai/code/session_01RL3gsnyHshwFzHxGZAwpDM