Feat/update user - #105
Open
Vlad-Skrekoten wants to merge 3 commits into
Open
Conversation
Reuses getUserById and mutates the record in place, returning undefined when the id does not exist so callers decide how to report "not found". Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Full-replace semantics: name and email are both required as non-empty strings and the email is shape-checked, so a partial body is a 400 rather than a silent half-update. The body is validated before the store lookup because a malformed request is a client error either way. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Write-up of the plan, the PUT-vs-PATCH and validation-ordering choices, the known GET/PUT invalid-id inconsistency, the commit split, and what the self-review caught. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.