Feature/update user endpoint - #11
Open
Sagaj-learn wants to merge 2 commits into
Open
Conversation
Implement the update-user endpoint and the store helper it needs:
- store.updateUser(id, {name, email}) mutates the matching user in place
and returns undefined when no user has that id, mirroring getUserById.
- PUT /users/:id validates input before looking the user up, so a missing
field on an existing id returns 400 (not 404), then maps an unknown id
to 404.
- Extract validateUserInput() and use it from both POST and PUT so the two
routes share one rule set: name and email must be non-empty trimmed
strings, email must look like an address. Values are trimmed before
storage, and a null/non-object body is tolerated.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Document the plan, model choice, commit split, and what the review caught, as required by the project grading. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.