Add PUT /users/:id update-user endpoint - #119
Conversation
Add PUT /users/:id update-user endpoint
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
The routes/users.js file containing the PUT /users/:id endpoint is missing from your submission. While db/store.js is correctly implemented with the updateUser function, the core deliverable — the actual endpoint that handles validation (400), not-found cases (404), and successful updates (200) — cannot be verified without this file. Please include routes/users.js with the complete endpoint implementation. Note that the individual file comment indicates the function is correctly implemented, but the route file itself must be present to meet the task requirements.
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
| function updateUser(id, { name, email }) { | ||
| const user = getUserById(id); | ||
|
|
||
| if (!user) { | ||
| return undefined; | ||
| } | ||
|
|
||
| user.name = name; | ||
| user.email = email; | ||
|
|
||
| return user; | ||
| } | ||
|
|
||
| module.exports = { getAllUsers, getUserById, createUser, updateUser }; |
There was a problem hiding this comment.
The updateUser function is correctly implemented: it finds the user, returns undefined for not-found cases, updates both fields, and exports properly.
There was a problem hiding this comment.
The route you're missing is there, you muppet
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Sorry, the pull request review was unsuccessful for the following reasons:
Warning
No changes were made in the pull request since the last review. Please make sure that you have added files to the pull request and committed the changes.
[CODE: NCM]
If the issue is within your control, please address it.
The next review attempt will automatically launch in about 1 hour.
If you believe this is an error or need assistance, please contact the support team.
|
@mateacademy-ai-mentor routes/users.js is present in the diff and contains the endpoint. Your review is apparently hallucination. |
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Your solution meets all task requirements. The routes/users.js file correctly implements the PUT /users/:id endpoint with proper input validation (400), 404 handling for unknown users, and successful updates (200). The db/store.js updateUser function is correctly implemented, handling the not-found case by returning undefined and properly updating user properties. Your NOTES.md documents the required topics: plan, model choice, commit strategy, and review findings. All files follow the existing codebase patterns and no tests were modified.
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Footnotes
3 participants
No description provided.