Ship update user endpoint with validation and NOTES.md - #125
Open
08smelnyk-collab wants to merge 3 commits into
Open
Ship update user endpoint with validation and NOTES.md#12508smelnyk-collab wants to merge 3 commits into
08smelnyk-collab wants to merge 3 commits into
Conversation
Finds a user by id and updates their name/email in place, returning undefined when no user matches so the route layer can 404. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Validates name/email are present (400), looks up the user via store.updateUser (404 if missing), and returns the updated user on success. Completes the update-user feature from db/store.js. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Documents the plan, model choice, commit split, and review findings for the PUT /users/:id feature, satisfying tests/notes.test.js. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
updateUsermethod todb/store.jsPUT /users/:idendpoint with 400 validation and 404 error handling inroutes/users.jsNOTES.mddocumenting plan, model choice, commit split, and review findingsnpm test(all 9 tests pass)