Add Finland weather CLI - #131
Closed
iirovpulkkinen-del wants to merge 1 commit into
Closed
Conversation
Fetches current conditions and 7-day forecasts for major Finnish cities from Open-Meteo, with Celsius/Fahrenheit output support.
mateacademy-ai-mentor
suggested changes
Sep 4, 2026
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
I am requesting changes because the submission does not implement the required Express endpoint and cannot satisfy the tests. The provided files include a Python CLI (weather.py) and skill.md, which are unrelated to the task of adding PUT /users/:id in an Express app. This is a critical blocker: there is no routes/users.js implementation or db/store.js integration, so the update functionality, validation (400 on invalid/missing fields), and proper 404 handling cannot be verified.
Critical issues to fix:
- Implement
PUT /users/:idin your Express routes (e.g.,routes/users.js), ensuringexpress.json()is applied before routes, theidis parsed consistently, and you return 200 with the updated user, 400 for validation errors, and 404 when the user does not exist. - Ensure data access follows the existing pattern via
db/store.jsand that tests expecting this pattern can run. - Add the required NOTES.md with the requested content so documentation checks pass.
Once these are added, re-run npm test to validate all cases. The weather CLI and skill.md are fine as context, but they do not meet the assignment’s core requirements. Keep going—you’re close once the correct endpoint and notes are in place.
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
Comment on lines
+1
to
+257
| #!/usr/bin/env python3 | ||
| """Print current weather statistics for major cities in Finland. | ||
|
|
||
| Data source: Open-Meteo (https://open-meteo.com) - free, no API key required. | ||
| Uses only the Python standard library. | ||
| """ | ||
|
|
||
| import argparse | ||
| import io | ||
| import json | ||
| import sys | ||
| import urllib.error | ||
| import urllib.request | ||
|
|
||
| # Force UTF-8 output so non-ASCII city names (e.g. "Jyväskylä") render | ||
| # correctly regardless of the terminal's default codepage (an issue on | ||
| # Windows, where the console often defaults to cp1252/cp850). | ||
| for _stream_name in ("stdout", "stderr"): | ||
| _stream = getattr(sys, _stream_name) | ||
| if isinstance(_stream, io.TextIOWrapper) and _stream.encoding.lower() != "utf-8": | ||
| setattr(sys, _stream_name, io.TextIOWrapper( | ||
| _stream.buffer, encoding="utf-8", errors="replace", newline="" | ||
| )) | ||
|
|
||
| API_URL = "https://api.open-meteo.com/v1/forecast" | ||
| CURRENT_FIELDS = ( | ||
| "temperature_2m,relative_humidity_2m,apparent_temperature," | ||
| "precipitation,weather_code,wind_speed_10m,wind_direction_10m" | ||
| ) | ||
| DAILY_FIELDS = ( | ||
| "weather_code,temperature_2m_max,temperature_2m_min," | ||
| "precipitation_sum,wind_speed_10m_max" | ||
| ) | ||
| FORECAST_DAYS = 7 | ||
| REQUEST_TIMEOUT_SECONDS = 10 | ||
| UNIT_SYMBOLS = {"celsius": "C", "fahrenheit": "F"} | ||
|
|
||
| CITIES = { | ||
| "Helsinki": (60.1699, 24.9384), | ||
| "Espoo": (60.2055, 24.6559), | ||
| "Tampere": (61.4978, 23.7610), | ||
| "Vantaa": (60.2934, 25.0378), | ||
| "Oulu": (65.0121, 25.4651), | ||
| "Turku": (60.4518, 22.2666), | ||
| "Jyväskylä": (62.2426, 25.7473), | ||
| "Lahti": (60.9827, 25.6612), | ||
| } | ||
|
|
||
| # WMO weather interpretation codes (subset covering common conditions). | ||
| WEATHER_CODES = { | ||
| 0: "Clear sky", | ||
| 1: "Mainly clear", | ||
| 2: "Partly cloudy", | ||
| 3: "Overcast", | ||
| 45: "Fog", | ||
| 48: "Depositing rime fog", | ||
| 51: "Light drizzle", | ||
| 53: "Moderate drizzle", | ||
| 55: "Dense drizzle", | ||
| 56: "Light freezing drizzle", | ||
| 57: "Dense freezing drizzle", | ||
| 61: "Slight rain", | ||
| 63: "Moderate rain", | ||
| 65: "Heavy rain", | ||
| 66: "Light freezing rain", | ||
| 67: "Heavy freezing rain", | ||
| 71: "Slight snow fall", | ||
| 73: "Moderate snow fall", | ||
| 75: "Heavy snow fall", | ||
| 77: "Snow grains", | ||
| 80: "Slight rain showers", | ||
| 81: "Moderate rain showers", | ||
| 82: "Violent rain showers", | ||
| 85: "Slight snow showers", | ||
| 86: "Heavy snow showers", | ||
| 95: "Thunderstorm", | ||
| 96: "Thunderstorm with slight hail", | ||
| 99: "Thunderstorm with heavy hail", | ||
| } | ||
|
|
||
|
|
||
| def condition_from_code(code): | ||
| return WEATHER_CODES.get(code, f"Unknown ({code})") | ||
|
|
||
|
|
||
| def compass_direction(degrees): | ||
| directions = ( | ||
| "N", "NNE", "NE", "ENE", "E", "ESE", "SE", "SSE", | ||
| "S", "SSW", "SW", "WSW", "W", "WNW", "NW", "NNW", | ||
| ) | ||
| index = round(degrees / 22.5) % 16 | ||
| return directions[index] | ||
|
|
||
|
|
||
| def fetch_current_weather(latitude, longitude, temperature_unit="celsius"): | ||
| query = ( | ||
| f"{API_URL}?latitude={latitude}&longitude={longitude}" | ||
| f"¤t={CURRENT_FIELDS}&temperature_unit={temperature_unit}" | ||
| f"&timezone=Europe/Helsinki" | ||
| ) | ||
| with urllib.request.urlopen(query, timeout=REQUEST_TIMEOUT_SECONDS) as response: | ||
| payload = json.load(response) | ||
| return payload["current"] | ||
|
|
||
|
|
||
| def fetch_city_weather(city, temperature_unit="celsius"): | ||
| latitude, longitude = CITIES[city] | ||
| return fetch_current_weather(latitude, longitude, temperature_unit) | ||
|
|
||
|
|
||
| def fetch_daily_forecast(latitude, longitude, temperature_unit="celsius"): | ||
| query = ( | ||
| f"{API_URL}?latitude={latitude}&longitude={longitude}" | ||
| f"&daily={DAILY_FIELDS}&forecast_days={FORECAST_DAYS}" | ||
| f"&temperature_unit={temperature_unit}&timezone=Europe/Helsinki" | ||
| ) | ||
| with urllib.request.urlopen(query, timeout=REQUEST_TIMEOUT_SECONDS) as response: | ||
| payload = json.load(response) | ||
| return payload["daily"] | ||
|
|
||
|
|
||
| def fetch_city_forecast(city, temperature_unit="celsius"): | ||
| latitude, longitude = CITIES[city] | ||
| return fetch_daily_forecast(latitude, longitude, temperature_unit) | ||
|
|
||
|
|
||
| def print_table(cities, temperature_unit="celsius"): | ||
| unit = UNIT_SYMBOLS[temperature_unit] | ||
| header = f"{'City':<12}{'Temp':>7}{'Feels':>8}{'Humidity':>10}{'Wind':>14} Condition" | ||
| print(header) | ||
| print("-" * len(header)) | ||
| for city in cities: | ||
| try: | ||
| current = fetch_city_weather(city, temperature_unit) | ||
| except (urllib.error.URLError, urllib.error.HTTPError, TimeoutError) as exc: | ||
| print(f"{city:<12} Error fetching weather data: {exc}") | ||
| continue | ||
|
|
||
| temp = f"{current['temperature_2m']:.1f}{unit}" | ||
| feels = f"{current['apparent_temperature']:.1f}{unit}" | ||
| humidity = f"{current['relative_humidity_2m']}%" | ||
| wind = f"{current['wind_speed_10m']:.0f} km/h {compass_direction(current['wind_direction_10m'])}" | ||
| condition = condition_from_code(current["weather_code"]) | ||
|
|
||
| print(f"{city:<12}{temp:>7}{feels:>8}{humidity:>10}{wind:>14} {condition}") | ||
|
|
||
|
|
||
| def print_single_city(city, temperature_unit="celsius"): | ||
| unit = UNIT_SYMBOLS[temperature_unit] | ||
| try: | ||
| current = fetch_city_weather(city, temperature_unit) | ||
| except (urllib.error.URLError, urllib.error.HTTPError, TimeoutError) as exc: | ||
| print(f"Error fetching weather data for {city}: {exc}", file=sys.stderr) | ||
| sys.exit(1) | ||
|
|
||
| print(f"Current weather in {city}") | ||
| print("-" * (len(city) + 20)) | ||
| print(f"Condition: {condition_from_code(current['weather_code'])}") | ||
| print(f"Temperature: {current['temperature_2m']:.1f} {unit}") | ||
| print(f"Feels like: {current['apparent_temperature']:.1f} {unit}") | ||
| print(f"Humidity: {current['relative_humidity_2m']}%") | ||
| print( | ||
| f"Wind: {current['wind_speed_10m']:.0f} km/h " | ||
| f"{compass_direction(current['wind_direction_10m'])}" | ||
| ) | ||
| print(f"Precipitation: {current['precipitation']} mm") | ||
| print(f"Observed at: {current['time']}") | ||
|
|
||
|
|
||
| def print_forecast_for_city(city, temperature_unit="celsius"): | ||
| unit = UNIT_SYMBOLS[temperature_unit] | ||
| try: | ||
| daily = fetch_city_forecast(city, temperature_unit) | ||
| except (urllib.error.URLError, urllib.error.HTTPError, TimeoutError) as exc: | ||
| print(f"Error fetching forecast for {city}: {exc}", file=sys.stderr) | ||
| return | ||
|
|
||
| title = f"{FORECAST_DAYS}-day forecast for {city}" | ||
| print(title) | ||
| print("-" * len(title)) | ||
| header = f"{'Date':<12}{'Condition':<22}{'High':>6}{'Low':>6}{'Precip':>9}{'Wind max':>11}" | ||
| print(header) | ||
| print("-" * len(header)) | ||
|
|
||
| days = zip( | ||
| daily["time"], | ||
| daily["weather_code"], | ||
| daily["temperature_2m_max"], | ||
| daily["temperature_2m_min"], | ||
| daily["precipitation_sum"], | ||
| daily["wind_speed_10m_max"], | ||
| ) | ||
| for date, code, high, low, precip, wind_max in days: | ||
| condition = condition_from_code(code) | ||
| high_str = f"{high:.1f}{unit}" | ||
| low_str = f"{low:.1f}{unit}" | ||
| precip_str = f"{precip:.1f}mm" | ||
| wind_str = f"{wind_max:.0f}km/h" | ||
| print(f"{date:<12}{condition:<22}{high_str:>6}{low_str:>6}{precip_str:>9}{wind_str:>11}") | ||
|
|
||
|
|
||
| def resolve_city(name): | ||
| for city in CITIES: | ||
| if city.lower() == name.lower(): | ||
| return city | ||
| return None | ||
|
|
||
|
|
||
| def main(): | ||
| parser = argparse.ArgumentParser( | ||
| description="Print current weather statistics for major cities in Finland." | ||
| ) | ||
| parser.add_argument( | ||
| "city", | ||
| nargs="?", | ||
| help="Print stats for a single city (case-insensitive). " | ||
| "Omit to print all cities.", | ||
| ) | ||
| parser.add_argument( | ||
| "-f", | ||
| "--forecast", | ||
| action="store_true", | ||
| help=f"Show a {FORECAST_DAYS}-day forecast instead of current conditions.", | ||
| ) | ||
| parser.add_argument( | ||
| "-u", | ||
| "--units", | ||
| choices=sorted(UNIT_SYMBOLS), | ||
| default="celsius", | ||
| help="Temperature unit to display (default: celsius).", | ||
| ) | ||
| args = parser.parse_args() | ||
|
|
||
| if args.city is None: | ||
| if args.forecast: | ||
| for index, city in enumerate(CITIES): | ||
| if index > 0: | ||
| print() | ||
| print_forecast_for_city(city, args.units) | ||
| else: | ||
| print_table(CITIES, args.units) | ||
| return | ||
|
|
||
| city = resolve_city(args.city) | ||
| if city is None: | ||
| valid = ", ".join(sorted(CITIES)) | ||
| print(f"Unknown city '{args.city}'. Valid choices: {valid}", file=sys.stderr) | ||
| sys.exit(1) | ||
|
|
||
| if args.forecast: | ||
| print_forecast_for_city(city, args.units) | ||
| else: | ||
| print_single_city(city, args.units) | ||
|
|
||
|
|
||
| if __name__ == "__main__": | ||
| main() |
There was a problem hiding this comment.
The submitted weather.py is a Python CLI application for fetching Finnish weather data from Open-Meteo API. This does not match the task requirements which ask for an Express.js endpoint (PUT /users/:id) to update users.
Comment on lines
+1
to
+88
| #!/usr/bin/env python3 | ||
| """Print current weather statistics for major cities in Finland. | ||
|
|
||
| Data source: Open-Meteo (https://open-meteo.com) - free, no API key required. | ||
| Uses only the Python standard library. | ||
| """ | ||
|
|
||
| import argparse | ||
| import io | ||
| import json | ||
| import sys | ||
| import urllib.error | ||
| import urllib.request | ||
|
|
||
| # Force UTF-8 output so non-ASCII city names (e.g. "Jyväskylä") render | ||
| # correctly regardless of the terminal's default codepage (an issue on | ||
| # Windows, where the console often defaults to cp1252/cp850). | ||
| for _stream_name in ("stdout", "stderr"): | ||
| _stream = getattr(sys, _stream_name) | ||
| if isinstance(_stream, io.TextIOWrapper) and _stream.encoding.lower() != "utf-8": | ||
| setattr(sys, _stream_name, io.TextIOWrapper( | ||
| _stream.buffer, encoding="utf-8", errors="replace", newline="" | ||
| )) | ||
|
|
||
| API_URL = "https://api.open-meteo.com/v1/forecast" | ||
| CURRENT_FIELDS = ( | ||
| "temperature_2m,relative_humidity_2m,apparent_temperature," | ||
| "precipitation,weather_code,wind_speed_10m,wind_direction_10m" | ||
| ) | ||
| DAILY_FIELDS = ( | ||
| "weather_code,temperature_2m_max,temperature_2m_min," | ||
| "precipitation_sum,wind_speed_10m_max" | ||
| ) | ||
| FORECAST_DAYS = 7 | ||
| REQUEST_TIMEOUT_SECONDS = 10 | ||
| UNIT_SYMBOLS = {"celsius": "C", "fahrenheit": "F"} | ||
|
|
||
| CITIES = { | ||
| "Helsinki": (60.1699, 24.9384), | ||
| "Espoo": (60.2055, 24.6559), | ||
| "Tampere": (61.4978, 23.7610), | ||
| "Vantaa": (60.2934, 25.0378), | ||
| "Oulu": (65.0121, 25.4651), | ||
| "Turku": (60.4518, 22.2666), | ||
| "Jyväskylä": (62.2426, 25.7473), | ||
| "Lahti": (60.9827, 25.6612), | ||
| } | ||
|
|
||
| # WMO weather interpretation codes (subset covering common conditions). | ||
| WEATHER_CODES = { | ||
| 0: "Clear sky", | ||
| 1: "Mainly clear", | ||
| 2: "Partly cloudy", | ||
| 3: "Overcast", | ||
| 45: "Fog", | ||
| 48: "Depositing rime fog", | ||
| 51: "Light drizzle", | ||
| 53: "Moderate drizzle", | ||
| 55: "Dense drizzle", | ||
| 56: "Light freezing drizzle", | ||
| 57: "Dense freezing drizzle", | ||
| 61: "Slight rain", | ||
| 63: "Moderate rain", | ||
| 65: "Heavy rain", | ||
| 66: "Light freezing rain", | ||
| 67: "Heavy freezing rain", | ||
| 71: "Slight snow fall", | ||
| 73: "Moderate snow fall", | ||
| 75: "Heavy snow fall", | ||
| 77: "Snow grains", | ||
| 80: "Slight rain showers", | ||
| 81: "Moderate rain showers", | ||
| 82: "Violent rain showers", | ||
| 85: "Slight snow showers", | ||
| 86: "Heavy snow showers", | ||
| 95: "Thunderstorm", | ||
| 96: "Thunderstorm with slight hail", | ||
| 99: "Thunderstorm with heavy hail", | ||
| } | ||
|
|
||
|
|
||
| def condition_from_code(code): | ||
| return WEATHER_CODES.get(code, f"Unknown ({code})") | ||
|
|
||
|
|
||
| def compass_direction(degrees): | ||
| directions = ( | ||
| "N", "NNE", "NE", "ENE", "E", "ESE", "SE", "SSE", |
There was a problem hiding this comment.
skill.md contains verification steps for weather.py, which is unrelated to the task of adding a user update endpoint to an Express API.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fetches current conditions and 7-day forecasts for major Finnish cities from Open-Meteo, with Celsius/Fahrenheit output support.