Add update user endpoint - #132
Open
iirovpulkkinen-del wants to merge 3 commits into
Open
Conversation
Follow the existing getUserById/createUser pattern: look the user up by id, apply the new fields, and return undefined if no such user exists so the route layer can turn that into a 404.
Validates name and email like the existing POST route, returns 404 for an unknown id, and 200 with the updated user otherwise.
Explains the plan, model choice, commit split, and self-review for the PUT /users/:id change.
mateacademy-ai-mentor
approved these changes
Sep 4, 2026
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Your solution is approved. The PUT /users/:id endpoint correctly validates name and email (returns 400 when missing), returns 404 for unknown IDs, and updates existing users as required. The db/store.js updateUser helper follows the established pattern and returns undefined when a user isn’t found, aligning with the rest of the store functions. NOTES.md clearly explains your plan, model choice, commit strategy, and review notes.
Minor suggestions (non-blocking):
- Consider returning a more specific 400 message indicating exactly which field(s) are missing to improve API usability.
- Optionally add a brief comment about the choice to validate before checking existence for clarity.
Nice work following the project’s conventions and meeting all functional requirements.
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Footnotes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.