-
Notifications
You must be signed in to change notification settings - Fork 158
Shipped change #143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Shipped change #143
Changes from all commits
c8da431
1c31f9e
a649f9a
820c2f2
f013cf7
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| I made Claude to create the plan. I approved the 1st and 2nd steps: add/implement the updateUser() function and add PUT handler to routes.js. 3rd step had no impact on the code. In the 4th step would have created and filled the NOTES.md file. I asked to skip it as I had to do that. I chose Sonnet for model because this task seemed not be too complex, and so the whole is cheaper. Two commits were asked: 1: store.js as it contains the updateUser() function; 2: users.js as it uses updateUser(). 3rd will contain NOTES.md. After saving this with content everything was fine, all tests were green. The review caught 1 bug, which was fixed in the 4th commit. | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There are grammar and clarity issues that make the meaning ambiguous (e.g., "I made Claude to create the plan", "3rd step had no impact on the code"). Please rewrite to plain language describing the plan you approved and any edits you made before approving. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The notes mention choosing the "Sonnet" model and that it was chosen to reduce cost — the course asked to state which model was chosen and why, which you've done, but consider also adding a sentence confirming that the tests passed locally (e.g., There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The closing sentence references a bug fixed in a "4th commit", but earlier you said there were only two (or three) commits. Make the commit count consistent: either list each commit and its purpose or correct the numbers so reviewers can follow the history. |
||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The file should clearly state what was actually changed (which files were modified and why). Right now it says steps were approved but doesn't explicitly confirm which files were committed or the final status besides "tests were green". Consider listing the actual commits or the exact files changed to make verification straightforward.