Add PUT /users/:id endpoint - #20
Open
BigGregory wants to merge 4 commits into
Open
Conversation
Updates an existing user by id, validating name/email like the existing POST route and returning 404 when the id doesn't match any user, following the same pattern as the other routes. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Guidance for Claude Code on commands and the server/routes/store architecture in this repo. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Write-up of the plan, model choice, commit split, and review for the update-user endpoint change. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013hEByGR54nTfEeiMkdGnwo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PUT /users/:idto update an existing user, validating thatnameandemailare present (400 if not)updateUserhelper indb/store.js, following the existing store patternTest plan
npm testpasses, including the providedtests/update-user.test.js(update, 404, 400 cases)Number("abc")→NaN) correctly falls through to 404 via strict equality ingetUserById, no crashPUT /users/:idwith a valid id, a missing id, and a missing field🤖 Generated with Claude Code