claude-ship-a-change-end-to-end - #22
Closed
tuitioner wants to merge 4 commits into
Closed
Conversation
Finds a user by id and overwrites name/email in place, returning undefined if the user doesn't exist so callers can 404.
Validates that name and email are present (400 otherwise), updates the user via store.updateUser, and returns 404 when the id doesn't exist. Mirrors the validation and not-found pattern already used by the POST and GET /:id routes.
Documents the plan, model choice, commit split, and self-review for the update-user endpoint.
Add PUT /users/:id (update user) endpoint
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two commits for the feature, plus this notes file:
db/store.js— add theupdateUserhelper (data layer).routes/users.js— add thePUT /:idroute that validates input andwires up the helper (API layer).
Splitting store from route keeps each commit reviewable on its own — the
data-access change and the HTTP/validation change are different concerns,
and this mirrors how
createUser/POSTandgetUserById/GET :idarealready split across the two files.