PR for changes made on the project claude-ship-a-change-end-to-end - #29
Open
robertomumo wants to merge 4 commits into
Open
PR for changes made on the project claude-ship-a-change-end-to-end#29robertomumo wants to merge 4 commits into
robertomumo wants to merge 4 commits into
Conversation
Adds store.updateUser(id, {name, email}) and the route handler,
following the existing GET/:id and POST validation/not-found patterns.
Makes tests/update-user.test.js green.
Self-review caught that updateUser reimplemented the same users.find id lookup already provided by getUserById.
Explains the plan, model choice, commit split, and what self-review caught, per the course write-up requirement.
Add PUT /users/:id endpoint to update a user
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notes.mdis included (plan, model choiced, commit split, and what review caught)After changes made,
npm testis green on my branch