Add PUT /users/:id update-user endpoint - #94
Closed
FelipeDeYcaza wants to merge 3 commits into
Closed
Conversation
Follows the existing getUserById/createUser pattern: looks the user up by id, returns null if missing so the route layer can 404, or mutates and returns the record in place.
Validates name/email are present (400 if not), 404s when the id doesn't match a user, otherwise updates and returns the record. Mirrors the existing GET /:id and POST / handlers.
Write-up of the plan, model choice, commit split, and what the self-review found for the update-user endpoint.
Author
|
Opened against the wrong repo by mistake — closing and resubmitting against my own fork. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
updateUser(id, { name, email })todb/store.js, following the existinggetUserById/createUserpatternPUT /users/:idtoroutes/users.js: validatesname/emailare present (400), 404s for an unknown id, otherwise updates and returns the user (200)NOTES.mdwith the plan, model choice, commit split, and review notesWhy
Ships the "update a user" feature described in the course README — the endpoint the pre-written
tests/update-user.test.jsgrades against.Test plan
npm test— all 9 tests pass, including the threeupdate-user.test.jscases (200 update, 404 unknown id, 400 missing field) and theNOTES.mdchecksnpm run lint— cleanPUT /users/1with a full body (200),PUT /users/9999with a full body (404), andPUT /users/1with onlyname(400)