Skip to content

Solution #3890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
voidmain69 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Solution #3890

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4a46a48
Solution
voidmain69 Aug 5, 2025
57356f6
rm slece
voidmain69 Aug 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 26 additions & 3 deletions src/herbivoresAndCarnivores.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,15 +1,38 @@
'use strict';

class Animal {
// write your code here
static alive = [];

constructor(name, health = 100) {
this.name = name;
this.health = health;
Animal.alive.push(this);
}
}

class Herbivore extends Animal {
// write your code here
hidden = false;

hide() {
this.hidden = true;
}
}

class Carnivore extends Animal {
// write your code here
bite(herbivore) {
if (!(herbivore instanceof Herbivore) || herbivore.hidden) {
return;
}
herbivore.health -= 50;

if (herbivore.health <= 0) {
const index = Animal.alive.indexOf(herbivore);

if (index !== -1) {
Animal.alive.splice(index, 1);

@mateacademy-ai-mentor mateacademy-ai-mentor Aug 5, 2025

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This violates the override instruction #2: 'It is preferred to filter animals with health less than or equal to 0 from Animal.alive array using Array's filter method.' Consider replacing the splice logic with a filter-based approach to remove dead animals from the Animal.alive array.

}
}
}
}

module.exports = {
Expand Down