implemantação da solução by Ricardo411 · Pull Request #3902 · mate-academy/js_herbivores_and_carnivores

Ricardo411 · 2025-08-12T14:29:41Z

implemantação da solução

Ricardo411 · 2025-08-12T14:30:46Z

implemantação da solução

mateacademy-ai-mentor

Review Summary

REQUEST_CHANGES

Thank you for your submission! Your implementation of the Animal, Herbivore, and Carnivore classes is clear and well-structured, and most requirements are met. However, there are two critical blockers that must be addressed before approval:

Removal of Dead Animals from Animal.alive (Checklist Item #2):
- Currently, you are using indexOf and splice to remove dead animals from the Animal.alive array. The requirements explicitly state that you must use the filter method for this purpose.
- How to fix: Replace your removal logic with:
```
Animal.alive = Animal.alive.filter(animal => animal.health > 0);
```
- This ensures compliance with the technical constraint and will pass the relevant tests.
Unnecessary Check in bite Method (Checklist Item #1):
- Your bite method currently checks if the target is in Animal.alive (Animal.alive.includes(target)). The requirements specify that you should only check if the target is an instance of Herbivore and is not hidden, all in a single if statement.
- How to fix: Remove the Animal.alive.includes(target) check from your if condition in the bite method.

Once you make these changes, your code should fully comply with the requirements. Great job on the rest of the implementation—you're very close! If you have any questions about the fixes, feel free to ask.

✨ Please rate this review in the Platform's notification center¹. I will be grateful for your feedback! ✨

Important

Fix the issues, commit the changes, and then re-request my review using the Re-request review button² in the Reviewers tab.

Tip

If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag³.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.

Caution

Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.

mateacademy-ai-mentor · 2025-08-12T14:31:39Z

+    const index = Animal.alive.indexOf(this);
+
+    if (index !== -1) {
+      Animal.alive.splice(index, 1);


This violates checklist item #2: 'Removal of dead animals from Animal.alive should be done using the filter method, not by using nested loops or indexOf + splice.'

You are using indexOf and splice to remove the animal. You must use Animal.alive = Animal.alive.filter(animal => animal.health > 0) or similar.

Ricardo411 · 2025-08-12T17:26:50Z

x

Ricardo411 · 2025-08-12T17:40:58Z

c

Ricardo411 · 2025-08-12T17:42:37Z

c

Ricardo411 · 2025-08-12T17:43:53Z

ffff

Ricardo411 · 2025-08-14T12:58:05Z

cc

Ricardo411 · 2025-08-15T19:13:49Z

reabri

Ricardo411 · 2025-08-15T19:39:28Z

reabrir

Ricardo411 · 2025-08-15T19:57:49Z

v

Ricardo411 · 2025-08-15T20:00:47Z

c

mateacademy-ai-mentor

Review Summary

This is an educational approval to help you continue progressing in your learning journey.

What you did well:

You implemented the Animal, Herbivore, and Carnivore classes using ES6 syntax and inheritance, which shows a solid grasp of JavaScript class structure.
The use of the static Animal.alive array and the filter method to manage living animals is correct and meets the requirements.
Your methods (hide and bite) are named and structured as specified, and you handled the logic for hiding and biting accurately.
The code is clean, concise, and avoids unnecessary checks or extra logic.

Areas for improvement:

Always double-check that your conditional checks (especially in methods like bite) are as concise as possible, using a single if statement when required.
Make sure that state changes (like removing dead animals from Animal.alive) happen immediately after the relevant action, as you did here.
Continue to pay attention to property defaults (like hidden = false for herbivores) and ensure they are set only where needed.

Keep up the great work! Your code meets all the functional and stylistic requirements for this task. As you move forward, keep focusing on clarity and precision in your logic—these are key skills for any developer. Well done!

✨ Please rate this review in the Platform's notification center¹. I will be grateful for your feedback! ✨

Rate AI review example ↩

mateacademy-ai-mentor

Sorry, the pull request review was unsuccessful for the following reasons:

Warning

No changes were made in the pull request since the last review. Please make sure that you have added files to the pull request and committed the changes.
_{[CODE: NCM]}

If the issue is within your control, please address it.
The next review attempt will automatically launch in about 1 hour.
If you believe this is an error or need assistance, please contact the support team.

mateacademy-ai-mentor

Sorry, the pull request review was unsuccessful for the following reasons:

Warning

No changes were made in the pull request since the last review. Please make sure that you have added files to the pull request and committed the changes.
_{[CODE: NCM]}

If the issue is within your control, please address it.
The next review attempt will automatically launch in about 1 hour.
If you believe this is an error or need assistance, please contact the support team.

mateacademy-ai-mentor

Sorry, the pull request review was unsuccessful for the following reasons:

Warning

No changes were made in the pull request since the last review. Please make sure that you have added files to the pull request and committed the changes.
_{[CODE: NCM]}

If the issue is within your control, please address it.
The next review attempt will automatically launch in about 1 hour.
If you believe this is an error or need assistance, please contact the support team.

mateacademy-ai-mentor

Sorry, the pull request review was unsuccessful for the following reasons:

Warning

No changes were made in the pull request since the last review. Please make sure that you have added files to the pull request and committed the changes.
_{[CODE: NCM]}

If the issue is within your control, please address it.
The next review attempt will automatically launch in about 1 hour.
If you believe this is an error or need assistance, please contact the support team.

raulriato

Normally, since the tests pass and the code looks okay, I would approve.

But you disabled eslint, so I'll request you to remove the comments.

raulriato · 2026-06-18T21:00:41Z

+
+  die() {
+    // Usar filter para manter apenas os animais com saúde maior que 0
+    // eslint-disable-next-line prettier/prettier


you should not leave comments on the project. Also, you should work your code to satisfy eslint rules, never disable eslint.

mateacademy-ai-mentor suggested changes Aug 12, 2025

View reviewed changes

Ricardo411 marked this pull request as draft August 12, 2025 17:27

Ricardo411 marked this pull request as ready for review August 12, 2025 17:40

Ricardo411 marked this pull request as draft August 12, 2025 17:41

Ricardo411 marked this pull request as ready for review August 12, 2025 17:42

Ricardo411 marked this pull request as draft August 12, 2025 17:46

Ricardo411 marked this pull request as ready for review August 12, 2025 19:42

Ricardo411 closed this Aug 13, 2025

Ricardo411 force-pushed the develop branch from e5d1492 to ae59795 Compare August 13, 2025 23:42

add solution

0e6096d

Ricardo411 reopened this Aug 15, 2025

Ricardo411 marked this pull request as draft August 15, 2025 19:47

Ricardo411 marked this pull request as ready for review August 15, 2025 19:49

Solution

56fb937

Ricardo411 requested a review from mateacademy-ai-mentor August 18, 2025 18:21

mateacademy-ai-mentor approved these changes Aug 18, 2025

View reviewed changes

mateacademy-ai-mentor reviewed Jun 17, 2026

View reviewed changes

raulriato suggested changes Jun 18, 2026

View reviewed changes

Uh oh!

Conversation

Ricardo411 commented Aug 12, 2025

Uh oh!

Ricardo411 commented Aug 12, 2025

Uh oh!

mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

Review Summary

Footnotes

Uh oh!

mateacademy-ai-mentor Aug 12, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Ricardo411 commented Aug 12, 2025

Uh oh!

Ricardo411 commented Aug 12, 2025

Uh oh!

Ricardo411 commented Aug 12, 2025

Uh oh!

Ricardo411 commented Aug 12, 2025

Uh oh!

Ricardo411 commented Aug 14, 2025

Uh oh!

Ricardo411 commented Aug 15, 2025

Uh oh!

Ricardo411 commented Aug 15, 2025

Uh oh!

Ricardo411 commented Aug 15, 2025

Uh oh!

Ricardo411 commented Aug 15, 2025

Uh oh!

mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

Review Summary

Footnotes

Uh oh!

mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

Uh oh!

mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

Uh oh!

mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

Uh oh!

mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

Uh oh!

raulriato left a comment

Choose a reason for hiding this comment

Uh oh!

raulriato Jun 18, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants