Skip to content

add task solution #3915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ViktorStupin wants to merge 2 commits into
base: master
Choose a base branch
from
Open

add task solution #3915

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6bc1e5d
add task solution
Aug 16, 2025
5bd0e24
add task solution
Aug 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 28 additions & 3 deletions src/herbivoresAndCarnivores.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,15 +1,40 @@
'use strict';

class Animal {
// write your code here
static alive = [];

constructor(name) {
this.name = name;
this.health = 100;
Animal.alive.push(this);
}
}

class Herbivore extends Animal {
// write your code here
constructor(name) {
super(name);
this.hidden = false;
}

hide() {
this.hidden = true;
}
}

class Carnivore extends Animal {
// write your code here
bite(animal) {
if (animal instanceof Herbivore && !animal.hidden) {
animal.health -= 50;

if (animal.health === 0) {

@mateacademy-ai-mentor mateacademy-ai-mentor Aug 16, 2025

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This violates the requirement that animals must be removed from Animal.alive when their health is less than or equal to 0. Your code only removes them when health === 0. It should be health <= 0.

const index = Animal.alive.indexOf(animal);

if (index > -1) {
Animal.alive.splice(index, 1);

@mateacademy-ai-mentor mateacademy-ai-mentor Aug 16, 2025

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This violates checklist item: 'The Animal.alive array must be updated using Array.prototype.filter to remove dead animals (with health <= 0). Avoid using nested loops or indexOf + splice for this purpose.'

You are using indexOf and splice instead of filter to remove dead animals from Animal.alive.

}
}
}
}
}

module.exports = {
Expand Down