js_herbivores_and_carnivores Develop - #3925
Open
DemetriodosAnjos wants to merge 1 commit into
Open
Conversation
mateacademy-ai-mentor
approved these changes
Aug 20, 2025
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Excellent work on this project! Your solution is well-structured, clean, and correctly implements all the requirements of the task.
Here are a few highlights:
- Strong OOP Implementation: You've demonstrated a great understanding of object-oriented principles, correctly using
extendsandsuper()to establish inheritance between your classes. - Logical Design: The
checkStatusmethod in theAnimalbase class is a fantastic design choice. It centralizes the responsibility for checking an animal's health and updating the staticAnimal.alivearray, which makes thebitemethod in theCarnivoreclass cleaner and more focused. - Attention to Detail: You've perfectly implemented all the specific logic, such as ensuring a
Carnivorecan only bite a non-hiddenHerbivoreand correctly usingfilter()to remove deceased animals from thealivearray.
Your code is complete, correct, and a pleasure to review. Keep up the great work!
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Footnotes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat: Add Animal, Herbivore, and Carnivore classes
Descrição:
Este pull request apresenta as classes "Animal", "Herbívoro" e "Carnívoro" para resolver a tarefa "Herbívoros e Carnívoros".
Inclui a lógica principal para saúde, movimento e interação entre animais.
Todos os problemas com linter e Prettier foram resolvidos.