resolving task - #4452
Conversation
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
The implementation uses the 'indexOf + splice' pattern to remove dead animals from Animal.alive, but the checklist requires using the 'filter' method instead. Replace the current logic with Animal.alive = Animal.alive.filter(aliveAnimal => aliveAnimal !== animal);
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
| if (animal.health <= 0) { | ||
| const animalIndex = Animal.alive.indexOf(animal); | ||
|
|
||
| if (animalIndex !== -1) { | ||
| Animal.alive.splice(animalIndex, 1); |
There was a problem hiding this comment.
Checklist item #1 violation: Use filter method instead of indexOf + splice to filter dead animals from Animal.alive. Replace the current logic with Animal.alive = Animal.alive.filter(aliveAnimal => aliveAnimal !== animal);
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Your implementation fully satisfies all task requirements. The code correctly implements class inheritance with Herbivore and Carnivore extending Animal, the bite method properly checks for both Herbivore instance and hidden status in a single condition, dead animals are correctly removed from Animal.alive using the filter method, and all edge cases are handled appropriately. The previous review concern about using indexOf + splice has been successfully resolved. Great work on this implementation!
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Footnotes
2 participants
No description provided.