Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions .github/workflows/test.yml-template
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
name: Test

on:
pull_request:
branches: [ master ]

jobs:
build:

runs-on: ubuntu-latest

strategy:
matrix:
node-version: [20.x]

steps:
- uses: actions/checkout@v2
- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v1
with:
node-version: ${{ matrix.node-version }}
- run: npm install
- run: npm test
9 changes: 5 additions & 4 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
"license": "GPL-3.0",
"devDependencies": {
"@mate-academy/eslint-config": "latest",
"@mate-academy/scripts": "^1.8.6",
"@mate-academy/scripts": "^2.1.3",
"eslint": "^8.57.0",
"eslint-plugin-jest": "^28.6.0",
"eslint-plugin-node": "^11.1.0",
Expand Down
40 changes: 36 additions & 4 deletions src/herbivoresAndCarnivores.js
Original file line number Diff line number Diff line change
@@ -1,15 +1,47 @@
'use strict';

'use strict';
class Animal {
// write your code here
static alive = [];

constructor(name) {
this.name = name;
this.health = 100;

Animal.alive.push(this);
}

removeIfDead() {
if (this.health <= 0) {
Animal.alive = Animal.alive.filter((animal) => animal !== this);
}
}
}

class Herbivore extends Animal {
// write your code here
constructor(name) {
super(name);
this.hidden = false;
}

hide() {
this.hidden = true;
}
}

class Carnivore extends Animal {
// write your code here
// eslint-disable-next-line no-useless-constructor
constructor(name) {
super(name);
}

bite(target) {

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The bite method should check target instanceof Herbivore instead of target instanceof Carnivore. The requirements state that bite takes a 'herbivore object' and should not work if it's 'another carnivore' - this means it should only work on Herbivores. Checking for Carnivore doesn't properly validate that the target is actually a Herbivore.

if (target instanceof Carnivore || target.hidden) {
return;
}

target.health -= 50;
target.removeIfDead();
}
}

module.exports = {
Expand Down
Loading