solution - #4460
Conversation
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
The code uses indexOf + splice to remove dead animals instead of the required filter method. Per CHECKLIST ITEM #1, replace Animal.alive.splice(Animal.alive.indexOf(herbivore), 1); with Animal.alive = Animal.alive.filter(animal => animal.health > 0);.
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
|
|
||
| if (herbivore.health <= 0) { | ||
| Animal.alive.splice(Animal.alive.indexOf(herbivore), 1); |
There was a problem hiding this comment.
This violates checklist item #1: use filter instead of indexOf + splice for removing dead animals from Animal.alive array. Consider using Animal.alive = Animal.alive.filter(animal => animal.health > 0);
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Your solution is approved. All requirements are correctly implemented: the Animal class has health (default 100) and name properties, Herbivore extends Animal with a working hide() method, Carnivore extends Animal with a bite() method that properly checks for instanceof Herbivore and hidden status before dealing 50 damage, and dead animals are correctly removed from the static Animal.alive array using the filter method as specified. The previous issue has been resolved and the code passes all checklist requirements.
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
No description provided.