Skip to content

solution - #4460

Open
LimeRider wants to merge 2 commits into
mate-academy:masterfrom
LimeRider:develop
Open

solution#4460
LimeRider wants to merge 2 commits into
mate-academy:masterfrom
LimeRider:develop

Conversation

@LimeRider

Copy link
Copy Markdown

No description provided.

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

The code uses indexOf + splice to remove dead animals instead of the required filter method. Per CHECKLIST ITEM #1, replace Animal.alive.splice(Animal.alive.indexOf(herbivore), 1); with Animal.alive = Animal.alive.filter(animal => animal.health > 0);.


✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨

Important

Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.

Tip

If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.

Caution

Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.

Footnotes

  1. Rate AI review example

  2. Re-request AI review example

  3. Add AI review comments example

Comment thread src/herbivoresAndCarnivores.js Outdated
Comment on lines +28 to +30

if (herbivore.health <= 0) {
Animal.alive.splice(Animal.alive.indexOf(herbivore), 1);

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This violates checklist item #1: use filter instead of indexOf + splice for removing dead animals from Animal.alive array. Consider using Animal.alive = Animal.alive.filter(animal => animal.health > 0);

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

Your solution is approved. All requirements are correctly implemented: the Animal class has health (default 100) and name properties, Herbivore extends Animal with a working hide() method, Carnivore extends Animal with a bite() method that properly checks for instanceof Herbivore and hidden status before dealing 50 damage, and dead animals are correctly removed from the static Animal.alive array using the filter method as specified. The previous issue has been resolved and the code passes all checklist requirements.


✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨

Footnotes

  1. Rate AI review example

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants