Solution - #4466
Conversation
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Your implementation correctly fulfills all functional requirements, but there's a checklist violation that needs to be addressed. In the checkHealth() method (lines 16-20), you're using the indexOf + splice pattern instead of the required filter method. Per [CHECKLIST ITEM #1], you must replace this with Animal.alive = Animal.alive.filter(animal => animal.health > 0);. While your current approach works functionally, the checklist explicitly requires using filter for managing the Animal.alive array. Please update your code to use the filter method and resubmit.
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
| if (this.health <= 0) { | ||
| const index = Animal.alive.indexOf(this); | ||
|
|
||
| if (index !== -1) { | ||
| Animal.alive.splice(index, 1); |
There was a problem hiding this comment.
This violates checklist item #1: Use filter instead of nested loops (indexOf + splice) for managing Animal.alive array. Replace indexOf + splice with Animal.alive = Animal.alive.filter(animal => animal.health > 0);
No description provided.