add solution - #4524
Conversation
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Your implementation has 2 explicit checklist violations that need to be addressed before approval. [CHECKLIST ITEM #1]: Replace the indexOf + splice pattern with the filter method when removing dead animals from the Animal.alive array. The functional approach using filter is required by the checklist. [CHECKLIST ITEM #2]: The hide method must set this.hidden = true instead of toggling with this.hidden = !this.hidden. Toggling can cause unexpected behavior if hide is called multiple times. The good news is your core inheritance structure and bite logic are working correctly—these are straightforward fixes to bring your code in line with the checklist requirements.
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
| if (this._health <= 0) { | ||
| const index = Animal.alive.indexOf(this); | ||
|
|
||
| Animal.alive.splice(index, 1); |
There was a problem hiding this comment.
Checklist Item #1 violation: Use filter method instead of indexOf + splice to remove dead animals from the Animal.alive array. The filter approach is preferred over manual index-based removal.
| hide() { | ||
| this.hidden = !this.hidden; |
There was a problem hiding this comment.
Checklist Item #2 violation: The hide method should set this.hidden to true, not toggle it. Change this.hidden = !this.hidden; to this.hidden = true;
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Your implementation is approved. The Animal base class correctly initializes health (default 100) and name properties while managing the static alive array. The Herbivore.hide() method properly sets hidden to true, and the Carnivore.bite() method accurately checks for Herbivore instances that are not hidden before dealing 50 damage. Dead animals are correctly removed from Animal.alive using the filter method when health drops to 0 or below. All task requirements and checklist items are satisfied.
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Footnotes
2 participants
No description provided.