task solution - #4531
Conversation
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Your implementation is functionally correct and all core requirements are met. However, it violates [CHECKLIST ITEM #1] by using indexOf + splice (lines 34-37) instead of the required filter method to remove dead animals from Animal.alive. While the current code works, the checklist explicitly requires using Animal.alive = Animal.alive.filter(animal => animal.health > 0); after the health reduction in the bite method. This is a clear requirement violation, so changes are needed before approval.
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
| if (target.health <= 0) { | ||
| const indexOfDead = Animal.alive.indexOf(target); | ||
|
|
||
| if (indexOfDead !== -1) { | ||
| Animal.alive.splice(indexOfDead, 1); |
There was a problem hiding this comment.
Checklist item #1 violation: Use filter method instead of indexOf + splice to remove dead animals from Animal.alive. The current implementation uses indexOf (line 34) and splice (line 37) with nested conditionals. Replace this pattern with Animal.alive = Animal.alive.filter(animal => animal.health > 0);
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Your solution correctly implements all requirements. The class hierarchy with Animal, Herbivore, and Carnivore is properly structured, and the bite method successfully removes dead animals using the filter method [CHECKLIST ITEM #1], which resolves the previous indexOf + splice issue. The default health of 100, the hide() method setting hidden to true, and the single if statement checking both instance type and hidden status are all implemented correctly. The static Animal.alive array properly tracks all living instances. Great work completing this exercise!
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Footnotes
2 participants
No description provided.